From f25d4f73c01ca46558f7a105702aa1d7a5278d54 Mon Sep 17 00:00:00 2001 From: Eddie Dong Date: Thu, 9 Jun 2011 16:24:09 +0800 Subject: [PATCH] Nested VMX: Emulation of guest vmptrld Signed-off-by: Qing He Signed-off-by: Eddie Dong Signed-off-by: Tim Deegan Committed-by: Tim Deegan --- xen/arch/x86/hvm/vmx/vmx.c | 6 ++- xen/arch/x86/hvm/vmx/vvmx.c | 66 ++++++++++++++++++++++++++++++ xen/include/asm-x86/hvm/vmx/vvmx.h | 3 ++ 3 files changed, 74 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index dd26c59595..cbd847910e 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2439,11 +2439,15 @@ asmlinkage void vmx_vmexit_handler(struct cpu_user_regs *regs) update_guest_eip(); break; + case EXIT_REASON_VMPTRLD: + if ( nvmx_handle_vmptrld(regs) == X86EMUL_OKAY ) + update_guest_eip(); + break; + case EXIT_REASON_MWAIT_INSTRUCTION: case EXIT_REASON_MONITOR_INSTRUCTION: case EXIT_REASON_VMCLEAR: case EXIT_REASON_VMLAUNCH: - case EXIT_REASON_VMPTRLD: case EXIT_REASON_VMPTRST: case EXIT_REASON_VMREAD: case EXIT_REASON_VMRESUME: diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 5f7028cb2e..ab5718f5b5 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -352,6 +352,25 @@ static void vmreturn(struct cpu_user_regs *regs, enum vmx_ops_result ops_res) regs->eflags = eflags; } +static void __map_io_bitmap(struct vcpu *v, u64 vmcs_reg) +{ + struct nestedvmx *nvmx = &vcpu_2_nvmx(v); + unsigned long gpa; + int index; + + index = vmcs_reg == IO_BITMAP_A ? 0 : 1; + if (nvmx->iobitmap[index]) + hvm_unmap_guest_frame (nvmx->iobitmap[index]); + gpa = __get_vvmcs(vcpu_nestedhvm(v).nv_vvmcx, vmcs_reg); + nvmx->iobitmap[index] = hvm_map_guest_frame_ro (gpa >> PAGE_SHIFT); +} + +static inline void map_io_bitmap_all(struct vcpu *v) +{ + __map_io_bitmap (v, IO_BITMAP_A); + __map_io_bitmap (v, IO_BITMAP_B); +} + /* * VMX instructions handling */ @@ -360,6 +379,7 @@ int nvmx_handle_vmxon(struct cpu_user_regs *regs) { struct vcpu *v=current; struct nestedvmx *nvmx = &vcpu_2_nvmx(v); + struct nestedvcpu *nvcpu = &vcpu_nestedhvm(v); struct vmx_inst_decoded decode; unsigned long gpa = 0; int rc; @@ -368,7 +388,22 @@ int nvmx_handle_vmxon(struct cpu_user_regs *regs) if ( rc != X86EMUL_OKAY ) return rc; + if ( nvmx->vmxon_region_pa ) + gdprintk(XENLOG_WARNING, + "vmxon again: orig %"PRIpaddr" new %lx\n", + nvmx->vmxon_region_pa, gpa); + nvmx->vmxon_region_pa = gpa; + + /* + * `fork' the host vmcs to shadow_vmcs + * vmcs_lock is not needed since we are on current + */ + nvcpu->nv_n1vmcx = v->arch.hvm_vmx.vmcs; + __vmpclear(virt_to_maddr(v->arch.hvm_vmx.vmcs)); + memcpy(nvcpu->nv_n2vmcx, v->arch.hvm_vmx.vmcs, PAGE_SIZE); + __vmptrld(virt_to_maddr(v->arch.hvm_vmx.vmcs)); + v->arch.hvm_vmx.launched = 0; vmreturn(regs, VMSUCCEED); return X86EMUL_OKAY; @@ -390,3 +425,34 @@ int nvmx_handle_vmxoff(struct cpu_user_regs *regs) return X86EMUL_OKAY; } +int nvmx_handle_vmptrld(struct cpu_user_regs *regs) +{ + struct vcpu *v = current; + struct vmx_inst_decoded decode; + struct nestedvcpu *nvcpu = &vcpu_nestedhvm(v); + unsigned long gpa = 0; + int rc; + + rc = decode_vmx_inst(regs, &decode, &gpa, 0); + if ( rc != X86EMUL_OKAY ) + return rc; + + if ( gpa == vcpu_2_nvmx(v).vmxon_region_pa || gpa & 0xfff ) + { + vmreturn(regs, VMFAIL_INVALID); + goto out; + } + + if ( nvcpu->nv_vvmcxaddr == VMCX_EADDR ) + { + nvcpu->nv_vvmcx = hvm_map_guest_frame_rw (gpa >> PAGE_SHIFT); + nvcpu->nv_vvmcxaddr = gpa; + map_io_bitmap_all (v); + } + + vmreturn(regs, VMSUCCEED); + +out: + return X86EMUL_OKAY; +} + diff --git a/xen/include/asm-x86/hvm/vmx/vvmx.h b/xen/include/asm-x86/hvm/vmx/vvmx.h index c218d36c67..70d2b3374a 100644 --- a/xen/include/asm-x86/hvm/vmx/vvmx.h +++ b/xen/include/asm-x86/hvm/vmx/vvmx.h @@ -152,5 +152,8 @@ enum vvmcs_encoding_type { u64 __get_vvmcs(void *vvmcs, u32 vmcs_encoding); void __set_vvmcs(void *vvmcs, u32 vmcs_encoding, u64 val); +void nvmx_destroy_vmcs(struct vcpu *v); +int nvmx_handle_vmptrld(struct cpu_user_regs *regs); + #endif /* __ASM_X86_HVM_VVMX_H__ */ -- 2.30.2